Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kopia: init at 0.5.2 #94462

Merged
merged 1 commit into from Aug 5, 2020
Merged

kopia: init at 0.5.2 #94462

merged 1 commit into from Aug 5, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Aug 1, 2020 •
edited

Motivation for this change
Things done

I only tested a "filesystem" backup for now.

Thanks to @infinisil for the help with the "vendor" thing.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit August 1, 2020 18:01
dasj19
dasj19 reviewed Aug 2, 2020
View reviewed changes
pkgs/tools/backup/kopia/default.nix
Comment on lines +18 to +21
# make 'vendor' writable
cp -L -r vendor tmp-vendor
rm -rf vendor
mv tmp-vendor vendor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just chmod +w vendor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a symlink pointing to the nix store. I should make the comment clearer.

@dasj19
Copy link
Contributor

dasj19 commented Aug 2, 2020

Built with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 94462" and runs fine. You can thick the 3rd checkbox in the description.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/246

jonringer
jonringer approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/94462
1 package built:
kopia

@jonringer jonringer merged commit 72ff02c into NixOS:master Aug 5, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Aug 5, 2020

Thank you very much.

@bbigras bbigras deleted the kopia branch August 11, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasj19 dasj19 dasj19 left review comments

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @dasj19 @nixos-discourse @jonringer