New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce BuildFHSUserEnv with Bubblewrap as an alternative to chrootenv #94442
Conversation
6183999
to
4359af9
Compare
4359af9
to
30f618e
Compare
I've come up with a cleaner solution to selectively use bubblewrap, will rebase to fix merge conflicts now |
30f618e
to
9ea8a3d
Compare
9ea8a3d
to
60aba8c
Compare
Just here to track @illegalprime's actual changes to build-fhs-userenv in the next commits
Allows us to talk to devices
60aba8c
to
3f5157f
Compare
Sorry but this is just bikeshedding at this point. The FHSEnv infrastructure is in need of a refactoring but that's WAY out of scope for this PR. Feel free to commit that stuff yourself (the branch is open) but honestly, it'd be better put in a separate PR. After we have deprecated chrootenv ideally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but consistent variable naming is not just bikeshedding. This is a builder and changing those variables later on can potentially break someones code.
The variable names are consistent with the original build-fhs-chrootenv. Many of your suggestions are actually on variable names from the original. Take a look at the blame. No, those names aren't what they should be but this PR is not a general refactoring of buildFHSUserEnv, variable names and code style. Intentionally so. Else it'd be going nowhere and end up with the same fate as the original PR. |
17b30fb
to
1bc200f
Compare
snake_case camelCase ;) |
Result of 1 package failed to build:- steam-run-native 10 packages built:- android-studio - androidStudioPackages.beta - androidStudioPackages.canary - androidStudioPackages.dev - kodiPlugins.steam-launcher - lutris - lutris-free - steam - steam-run - steamcmd |
Steam broke because of gstreamer, so it is unrelated. |
@GrahamcOfBorg eval |
It's actually just the -native version, the regular (steamrt) steam is fine. Was the nix-update hash change intended? That seems out of place. |
No sorry. I was testing nix-update with nix-update and it staged this file. |
c6de416
to
dca51dc
Compare
Fixed via force push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge after next eval.
Thank you! |
to include NixOS/nixpkgs#94442 for a working steam
Motivation for this change
#55973 (comment)
Fixes #92798
/cc @Mic92 @illegalprime
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)