Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoin: 0.20.0 -> 0.20.1 #94480

Merged
merged 1 commit into from Aug 13, 2020
Merged

bitcoin: 0.20.0 -> 0.20.1 #94480

merged 1 commit into from Aug 13, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Aug 1, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested a review from mmahut as a code owner August 1, 2020 21:03
roconnor
roconnor reviewed Aug 10, 2020
View reviewed changes
pkgs/applications/blockchains/bitcoin.nix
@@ -40,7 +36,7 @@ stdenv.mkDerivation rec {
"https://bitcoincore.org/bin/bitcoin-core-${version}/bitcoin-${version}.tar.gz"
"https://bitcoin.org/bin/bitcoin-core-${version}/bitcoin-${version}.tar.gz"
];
sha256 = "ec5a2358ee868d845115dc4fc3ed631ff063c57d5e0a713562d083c5c45efb28";
sha256 = "4bbd62fd6acfa5e9864ebf37a24a04bc2dcfe3e3222f056056288d854c53b978";
Copy link
Contributor

@roconnor roconnor Aug 10, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that this hash, 4bbd62fd6acfa5e9864ebf37a24a04bc2dcfe3e3222f056056288d854c53b978, is signed by Bitcoin Core binary release signing key.

@roconnor
Copy link
Contributor

Anyone know what's up with this BITCOIN_GENBUILD_NO_GIT=1 thing? Is it something we should be doing?

@roconnor
Copy link
Contributor

According to my reading of http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-05-14-19.00.log.html we are probably fine, but it would be much safer to engage that environment variable. (h/t to yoghurt for finding me those meeting notes).

I would strongly encourage you to add BITCOIN_GENBUILD_NO_GIT=1 to the build environment at least for this version of bitcoin.

@prusnak
Copy link
Member Author

prusnak commented Aug 10, 2020

I would strongly encourage you to add BITCOIN_GENBUILD_NO_GIT=1 to the build environment at least for this version of bitcoin.

Addressed in b5a5bf2f7949ce128eb5522af10efb79fe860bd8

@ofborg ofborg bot requested a review from roconnor August 11, 2020 02:12
@roconnor
Copy link
Contributor

(1) I think that export command has no effect.
(2) Upon closer inspection of genbuild.sh it seems that having git unavailable is equivalent.

Based on (2) I'm not so sure anymore that it is worthwhile doing anything.

@prusnak
Copy link
Member Author

prusnak commented Aug 11, 2020

Removed BITCOIN_GENBUILD_NO_GIT in 411c318

@roconnor
Copy link
Contributor

LGTM. Sorry for the back and forth.

roconnor
roconnor approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@roconnor roconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mmahut mmahut merged commit 3354811 into NixOS:master Aug 13, 2020
@prusnak prusnak deleted the bitcoin branch August 13, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roconnor roconnor roconnor approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @roconnor @mmahut