Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk: 11.0.7 -> 11.0.8 #94528

Merged
merged 1 commit into from Aug 2, 2020
Merged

openjdk: 11.0.7 -> 11.0.8 #94528

merged 1 commit into from Aug 2, 2020

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Aug 2, 2020

Also added minor variable to reflect namin schme introduced in java 9: https://bugs.openjdk.java.net/browse/JDK-8061493

Motivation for this change

Switched to most recent update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
 asbachb@nixos  ~/dev/src/nix/nixpkgs   update-java11  nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
these paths will be fetched (0.03 MiB download, 0.13 MiB unpacked):
  /nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1
copying path '/nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 11, done.
remote: Counting objects: 100% (11/11), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 11 (delta 5), reused 7 (delta 5), pack-reused 0
Unpacking objects: 100% (11/11), 2.90 KiB | 742.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   e0f07f9b8d7..ad7c4e495a4  master     -> refs/nixpkgs-review/0
$ git worktree add /home/asbachb/.cache/nixpkgs-review/rev-07ba3e512768147b5f4e679fac60f66e6e761db3-dirty/nixpkgs ad7c4e495a4aa2838e5068d05bbd4f2b56b3731f
Preparing worktree (detached HEAD ad7c4e495a4)
Updating files: 100% (22269/22269), done.
HEAD is now at ad7c4e495a4 Merge pull request #94514 from r-ryantm/auto-update/kmon
$ nix-env -f /home/asbachb/.cache/nixpkgs-review/rev-07ba3e512768147b5f4e679fac60f66e6e761db3-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asbachb
openjdk: 11.0.7 -> 11.0.8
56cff95 
Also added `minor` variable to reflect naming scheme introduced in java 9: https://bugs.openjdk.java.net/browse/JDK-8061493
@ofborg ofborg bot requested a review from edwtjo August 2, 2020 07:10
@Ma27 Ma27 merged commit 7dd96f8 into NixOS:master Aug 2, 2020
@jerith666 jerith666 mentioned this pull request Aug 6, 2020
Closed
10 tasks
@asbachb asbachb deleted the update-java11 branch January 25, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asbachb @Ma27