Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows: narrow pull_request event types #94511

Closed
wants to merge 1 commit into from
Closed

.github/workflows: narrow pull_request event types #94511

wants to merge 1 commit into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Aug 2, 2020 •
edited

Motivation for this change

pull_request is triggered in various event types, from assigned to merged but these workflows don't need to be executed in these events.

I hope guess this would fix the mysterious GitHub actions failures.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
.github/workflows: narrow pull_request event types
a6d3a55 
GitHub pull_request event is triggered in a broad types, which triggers
these workflows unnecessarily.
@marsam marsam requested review from Mic92 and zowoq August 2, 2020 03:59
@marsam
Copy link
Contributor Author

marsam commented Aug 2, 2020

maybe it's also necessary to enable this option? https://github.community/t/workflow-error-action-not-allowed/16788/4

@zowoq
Copy link
Contributor

zowoq commented Aug 2, 2020

Actions seem to be broken for all repos in the org, I guess we'll need to wait for one of the org owners.

There has been some discussion on #nixos-dev as well.

@marsam marsam closed this Aug 2, 2020
@marsam marsam deleted the narrow-github-action branch August 2, 2020 07:11
@Mic92 Mic92 mentioned this pull request Aug 2, 2020
Merged
@domenkozar
Copy link
Member

I've enabled third party Actions for whole organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @zowoq @domenkozar @Mic92