postfix: 3.5.4 -> 3.5.6 #94457
Merged
postfix: 3.5.4 -> 3.5.6 #94457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test postfix postfix-raise-smtpd-tls-security |
|
|
|
❯ nix-build nixos/tests/postfix.nix
error:
Failed assertions:
- The option definition `services.postfix.sslCACert' in `<unknown-file>' no longer has any effect; please remove it.
services.postfix.sslCACert was replaced by services.postfix.tlsTrustedAuthorities. In case you intend that your server should validate requested client certificates use services.postfix.extraConfig.
(use '--show-trace' to show detailed location information)The fix should be as simple as diff --git a/nixos/tests/postfix.nix b/nixos/tests/postfix.nix
index 0d677427d76..9dbcf689122 100644
--- a/nixos/tests/postfix.nix
+++ b/nixos/tests/postfix.nix
@@ -1,4 +1,4 @@
-let
+let
certs = import ./common/acme/server/snakeoil-certs.nix;
in
import ./make-test-python.nix {
@@ -10,7 +10,7 @@ import ./make-test-python.nix {
enable = true;
enableSubmission = true;
enableSubmissions = true;
- sslCACert = certs.ca.cert;
+ tlsTrustedAuthorities = certs.ca.cert;
sslCert = certs."acme.test".cert;
sslKey = certs."acme.test".key;
submissionsOptions = { |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
http://www.postfix.org/announcements/postfix-3.5.6.html
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)