opengrm-ngram: init at 1.3.11, phonetisaurus: init at 2020-07-31 #94465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
commented
Aug 1, 2020
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "phonetisaurus"; | ||
| version = "2020-07-31"; |
There was a problem hiding this comment.
Needs to be unstable to be compatible with openfst.
There was a problem hiding this comment.
I asked for a release here: AdolfVonKleist/Phonetisaurus#61
|
This is a preparation for rhasspy. |
Mic92
commented
Aug 1, 2020
Comment on lines
27139
to
+27143
| openfst = callPackage ../development/libraries/openfst {}; | ||
|
|
||
| opengrm-ngram = callPackage ../development/libraries/opengrm-ngram {}; | ||
|
|
||
| phonetisaurus = callPackage ../development/libraries/phonetisaurus {}; |
There was a problem hiding this comment.
All three are related so I keep them together.
|
Result of 2 packages built:- opengrm-ngram - phonetisaurus |
mweinelt
reviewed
Aug 1, 2020
Co-authored-by: Martin Weinelt <mweinelt@users.noreply.github.com>
|
rebased! |
|
merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a preparation for rhasspy.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)