Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sfrotz: init at 2.52 #94463

Merged
merged 1 commit into from Aug 6, 2020
Merged

sfrotz: init at 2.52 #94463

merged 1 commit into from Aug 6, 2020

Conversation

ddelabru
Copy link
Contributor

@ddelabru ddelabru commented Aug 1, 2020 •
edited

sfrotz is an SDL interface version of frotz, the Z-machine interpreter which plays both Infocom games and newer games targeting the Z-machine. Unlike the curses interface version of Frotz, SDL Frotz can handle the graphics in Z-machine version 6 games.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ddelabru
Copy link
Contributor Author

ddelabru commented Aug 1, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 1, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

srhb
srhb requested changes Aug 6, 2020
View reviewed changes
pkgs/games/sfrotz/default.nix Outdated Show resolved Hide resolved
pkgs/games/sfrotz/default.nix Outdated Show resolved Hide resolved
pkgs/games/sfrotz/default.nix Outdated Show resolved Hide resolved
pkgs/games/sfrotz/default.nix Outdated Show resolved Hide resolved
@srhb
Copy link
Contributor

srhb commented Aug 6, 2020

@ofborg build sfrotz

srhb
srhb reviewed Aug 6, 2020
View reviewed changes
pkgs/games/sfrotz/default.nix Outdated Show resolved Hide resolved
@ddelabru
sfrotz: init at 2.52
5efc22d 
sfrotz is an SDL interface version of frotz, the Z-machine interpreter which plays both Infocom games and newer games targeting the Z-machine. Unlike the curses interface version of Frotz, SDL Frotz can handle the graphics in Z-machine version 6 games.
srhb
srhb approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Just letting ofborg have another go 👍

@ddelabru
Copy link
Contributor Author

ddelabru commented Aug 6, 2020

@srhb Thanks for helping me improve! For what it's worth, I've got a pull request to update another package that builds from the same code base (the curses interface for frotz). It's #94464. A little simpler than this one.

@srhb srhb merged commit fd8e611 into NixOS:master Aug 6, 2020
@ddelabru ddelabru deleted the add-sfrotz branch January 28, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ddelabru @srhb