New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homeassistant: 0.113.0 -> 0.113.3 #94475
Conversation
@GrahamcOfBorg build homeassistant |
I am currently seeing this test error: |
@GrahamcOfBorg build home-assistant |
I also tried to rebase this on upstream/master but it seems to be still a problem. Not sure why this is not triggered here. |
Mhm. Now it seems to work for me as well? Maybe its a flacky test? |
Indeed is flaky, I didn't run into this issue when I first ran the test, now I do. The test was introduced in 0.113.2: home-assistant/core#38311 |
The timeout given here is probably a bit too tight: diff --git a/tests/test_core.py b/tests/test_core.py
index 12ed00fde2..877eac226a 100644
--- a/tests/test_core.py
+++ b/tests/test_core.py
@@ -1447,7 +1447,7 @@ async def test_chained_logging_hits_log_timeout(hass, caplog):
return
hass.async_create_task(_task_chain_1())
- with patch.object(ha, "BLOCK_LOG_TIMEOUT", 0.0001):
+ with patch.object(ha, "BLOCK_LOG_TIMEOUT", 0.001):
hass.async_create_task(_task_chain_1())
await hass.async_block_till_done() I'll raise this issue upstream. |
Ok. We can apply the pull request patch. |
Spoke too quick, that doesn't fix it for me. |
Upstream issue home-assistant/core#38476 |
Done. |
Motivation for this change
https://github.com/home-assistant/core/releases/tag/0.113.1
https://github.com/home-assistant/core/releases/tag/0.113.2
https://github.com/home-assistant/core/releases/tag/0.113.3
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)@GrahamcOfBorg test home-assistant