Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initrd-network: fix flushBeforeStage2 #94531

Merged
merged 1 commit into from Aug 2, 2020
Merged

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented Aug 2, 2020

Motivation for this change

Network interfaces are not properly shutdown before stage2 despite boot.initrd.network.flushBeforeStage2 being set.
This is the error message printed on the screen:

ip: invalid argument 'down' to 'ip'
Things done
  • Use a correct syntax for the ip command.
  • Use the optional "dev" prefix. Not done because it would required to change more lines accross the stage1 init, but this would be cleaner.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mweinelt mweinelt merged commit 6c14056 into NixOS:master Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants