Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liquidprompt: unstable-2018-05-21 -> 1.12.0 #94495

Merged
merged 1 commit into from Aug 10, 2020
Merged

liquidprompt: unstable-2018-05-21 -> 1.12.0 #94495

merged 1 commit into from Aug 10, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Aug 2, 2020

Motivation for this change

Update to version 1.12.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Gerschtli August 2, 2020 00:37
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/242

Gerschtli
Gerschtli approved these changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@Gerschtli Gerschtli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, tested locally

@romildo romildo merged commit d3a7373 into NixOS:master Aug 10, 2020
@romildo romildo deleted the upd.liquidprompt branch August 10, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerschtli Gerschtli Gerschtli approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @nixos-discourse @Gerschtli