Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/postfix: migrate test to use tlsTrustedAuthorities #94484

Merged
merged 2 commits into from Nov 12, 2020
Merged

nixos/tests/postfix: migrate test to use tlsTrustedAuthorities #94484

merged 2 commits into from Nov 12, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Aug 1, 2020

Motivation for this change

This fixes the tests to work after 632104e.

Discovered in #94457 (comment).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member Author

mweinelt commented Aug 1, 2020

CC @asbachb

@mweinelt
Copy link
Member Author

mweinelt commented Aug 2, 2020

This also adds passthru.tests.

@mweinelt mweinelt mentioned this pull request Aug 2, 2020
Merged
10 tasks
@mweinelt
Copy link
Member Author

mweinelt commented Sep 3, 2020

Hey @asbachb, can you please check this?

@asbachb
Copy link
Contributor

asbachb commented Sep 11, 2020

@mweinelt tbh I don't feel competent enough with nixos testsing to approve the changes.

/cc @peti @nlewo can you help out?

nlewo
nlewo approved these changes Oct 25, 2020
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the latency :(
Could you rebase?

@mweinelt
Copy link
Member Author

error: value is a function while a set was expected, at /home/hexa/git/nixos/master/nixos/tests/postfix.nix:14:19

I tried rebasing it, but now fails like so. Seems to have issues accesssing certs.ca.cert?

@nlewo nlewo mentioned this pull request Nov 5, 2020
Merged
10 tasks
@mweinelt
nixos/tests/postfix: migrate test to use tlsTrustedAuthorities
1b5a1c6 
Fixes: 632104e ("postfix: deprecated `sslCACert` in favour of
`tlsTrustedAuthorities`")
@mweinelt
postfix: add passthru tests
9309563
@mweinelt
Copy link
Member Author

@nlewo Fixed!

@nlewo
Copy link
Member

nlewo commented Nov 12, 2020

@mweinelt Cool! Thank you.

@nlewo nlewo merged commit d73f269 into NixOS:master Nov 12, 2020
@mweinelt mweinelt deleted the postfix branch November 12, 2020 19:53
@mweinelt mweinelt mentioned this pull request Apr 14, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo approved these changes

@rickynils rickynils Awaiting requested review from rickynils

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mweinelt @asbachb @nlewo @ryantm @ajs124