Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.async-upnp-client: init at 0.14.14 #94487

Merged
merged 3 commits into from Aug 2, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Aug 1, 2020

Motivation for this change

Enables the UPNP and DLNA components in home-assistant.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the home-assistant changes should probably go into a different commit, as they aren't directly related to the python package additions

@mweinelt
Copy link
Member Author

mweinelt commented Aug 2, 2020

Updated.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 94487 1

59 packages marked as broken and skipped: - clang-sierraHack-stdenv - crossLibcStdenv - digitalbitbox - iterm2 - linuxPackages-libre.sch_cake - linuxPackages.sch_cake - linuxPackages_4_14.sch_cake - linuxPackages_4_4.evdi - linuxPackages_4_4.sysdig - linuxPackages_4_4.zenpower - linuxPackages_4_9.sysdig - linuxPackages_4_9.zenpower - linuxPackages_5_6.sch_cake - linuxPackages_5_7.sch_cake - linuxPackages_hardkernel_4_14.bcc - linuxPackages_hardkernel_4_14.bpftrace - linuxPackages_hardkernel_4_14.can-isotp - linuxPackages_hardkernel_4_14.chipsec - linuxPackages_hardkernel_4_14.digimend - linuxPackages_hardkernel_4_14.evdi - linuxPackages_hardkernel_4_14.mba6x_bl - linuxPackages_hardkernel_4_14.nvidia_x11 - linuxPackages_hardkernel_4_14.nvidiabl - linuxPackages_hardkernel_4_14.prl-tools - linuxPackages_hardkernel_4_14.r8125 - linuxPackages_hardkernel_4_14.r8168 - linuxPackages_hardkernel_4_14.rtl8814au - linuxPackages_hardkernel_4_14.rtl8821au - linuxPackages_hardkernel_4_14.rtl8821ce - linuxPackages_hardkernel_4_14.rtl88xxau-aircrack - linuxPackages_hardkernel_4_14.rtlwifi_new - linuxPackages_hardkernel_4_14.sch_cake - linuxPackages_hardkernel_4_14.sysdig - linuxPackages_hardkernel_4_14.vhba - linuxPackages_hardkernel_4_14.virtualbox - linuxPackages_hardkernel_4_14.virtualboxGuestAdditions - linuxPackages_hardkernel_4_14.wireguard - linuxPackages_hardkernel_4_14.xpadneo - linuxPackages_hardkernel_4_14.zenpower - linuxPackages_latest_xen_dom0.sch_cake - linuxPackages_latest_xen_dom0_hardened.sch_cake - linuxPackages_xen_dom0_hardened.sch_cake - newlibCross - ocamlPackages.stog - php72Packages.phpmd - php73Extensions.pcs - php73Extensions.zmq - php73Packages.phpmd - php74Extensions.pcs - php74Extensions.pthreads - python27Packages.caffe - python38Packages.libselinux - python38Packages.nixpart - python38Packages.pyblock - steam-run-native - tqsl - uclibcCross - ucommon - xpdf
4 packages built: - python37Packages.async-upnp-client - python37Packages.python-didl-lite - python38Packages.async-upnp-client - python38Packages.python-didl-lite

@jonringer jonringer merged commit 48ec2fb into NixOS:master Aug 2, 2020
@mweinelt mweinelt deleted the async-upnp-client branch August 2, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants