Add: Extend DECLARE_ENUM_AS_BIT_SET with extra operations #8254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to simplify, and lower the cognitive overhead of, the common operations of setting, clearing, and interrogating bits of the various enums that are used as bitsets within the codebase.
For example:
flags |= bits
==>flags += bits
flags &= ~bits
==>flags -= bits
flags & mask != 0
==>any(flags, mask)
,flags & mask == 0
==>none(flags, mask)
flags & mask == mask
==>all(flags, mask)
,flags & bit != 0
==>test(flags, bit)
I originally tried
<=
and>=
as subset and superset operators (respectively), but that seems to interfere with the builtin operators and break stuff; and I don't think we have any actual use cases for them anyway.