Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telepathy-qt: 0.9.7 -> 0.9.8 #91957

Merged
merged 1 commit into from Jul 2, 2020
Merged

telepathy-qt: 0.9.7 -> 0.9.8 #91957

merged 1 commit into from Jul 2, 2020

Conversation

HenkKalkwater
Copy link
Contributor

@HenkKalkwater HenkKalkwater commented Jul 1, 2020 •
edited

Motivation for this change

Telepathy 0.9.8 has been out for quite some while.

  • telepathy 0.9.8 no longer supports Qt 4, so telepathy-qt and telepathy_qt now throw an error suggesting to use the Qt 5 packages instead.
  • telepathy 0.9.8 uses Python 3 instead of Python 2, so that has been corrected in the package.
  • telepathy 0.9.8 includes the patch that was previously manually added, so therefore it has been removed from the package.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
4 packages updated:
telepathy-qt (0.9.7 → 0.9.8) telepathy_qt (0.9.7 → 0.9.8) telepathy_qt5 (0.9.7 → 0.9.8) libsForQt5.telepathy (0.9.7 → 0.9.8)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@HenkKalkwater
Copy link
Contributor Author

HenkKalkwater commented Jul 1, 2020 •
edited

It should also remove a duplicate callPackage, ticking one extra box for #39840

jonringer
jonringer approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/91957
1 package built:
telepathy-qt

going to let more qt-savy people merge though
cc @worldofpeace @jtojnar

@jtojnar
Copy link
Contributor

jtojnar commented Jul 1, 2020 •
edited

Changes are looking okay at a glance:

https://github.com/TelepathyIM/telepathy-qt/releases/tag/telepathy-qt-0.9.8
TelepathyIM/telepathy-qt@telepathy-qt-0.9.7...telepathy-qt-0.9.8

jtojnar
jtojnar reviewed Jul 2, 2020
View reviewed changes
pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@HenkKalkwater
telepathy-qt: 0.9.7 -> 0.9.8
e2c7423 
* telepathy 0.9.8 no longer supports Qt 4, so telepathy-qt and
  telepathy_qt now throw an error suggesting to use the Qt 5 packages
  instead.
* telepathy 0.9.8 uses Python 3 instead of Python 2, so that has been
  corrected in the package.
* telepathy 0.9.8 includes the patch that was previously manually added,
  so therefore it is removed from the package.
@jtojnar jtojnar merged commit c1e2731 into NixOS:master Jul 2, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jul 2, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HenkKalkwater @jtojnar @jonringer