platformio: Add udev rules to package output #92000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The udev rules shipped with platformio are not part of the package output. This is a follow up to #91679 (I'll close the PR when this gets merged)
Things done
Put the udev rules into
$out/lib/udev/rules.d/99-platformio-udev.rules
. This also adds a patch to change the default warning when the rules are not found to a more NixOS specific message.Some things feel weird for me:
1.) Is calling
fetchFromGitHub
in multiple places with the same arguments considered good style? I could not think of a better way to do this.2.) Is patching a appropriate way to inform about the usage of the udev rules?
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)