Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owncloud-client: add libsecret dependency #92046

Merged
merged 1 commit into from Jul 2, 2020
Merged

owncloud-client: add libsecret dependency #92046

merged 1 commit into from Jul 2, 2020

Conversation

fabianhauser
Copy link
Member

The libsecret dependency is required to access secrets from the gnome keyring. (The same is included in the (nearly identical) nextcloud-client)

If possible, it would be great if we could backport this to 20.03.

Motivation for this change

I would like to use the account login from my gnome-keyring with the owncloud-client package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabianhauser
owncloud-client: add libsecret dependency
4f276b8 
The libsecret dependency is required to access secrets from the gnome keychain.
@das-g
Copy link
Member

das-g commented Jul 2, 2020

Result of nixpkgs-review pr 92046 1

1 package built:
- owncloudclient (owncloud-client)

@ofborg ofborg bot requested a review from qknight July 2, 2020 13:33
@bjornfor bjornfor merged commit cf0552d into NixOS:master Jul 2, 2020
@bjornfor
Copy link
Contributor

bjornfor commented Jul 2, 2020

Backported to release-20.03: cf0552d.

@fabianhauser fabianhauser deleted the owncloud-libsecret branch July 2, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@qknight qknight Awaiting requested review from qknight

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabianhauser @das-g @bjornfor