New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc static cross fixes #91975
Misc static cross fixes #91975
Conversation
4a8b035
to
80ba806
Compare
@@ -276,4 +280,28 @@ in { | |||
libev = super.libev.override { static = true; }; | |||
|
|||
libexecinfo = super.libexecinfo.override { enableShared = false; }; | |||
|
|||
xorg = super.xorg.overrideScope' (xorgself: xorgsuper: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be preferably to introduce some kind of enableStatic
option in the xorg derivations, if possible, but I guess that is difficult because they are "generated" and then overridden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can change the signature of a function while overriding...
In any case I'd rather see something like #83664 implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible with something like
libXxf86dga = lib.makeOverrideable ({enableStatic, ... } @attrs: super.libXxf86dga.overrideAttrs(oldAttrs: {
} // attrs));
but yea, not really worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK.
I expect the rebuilds are mainly because of libjpeg(-turbo).
Motivation for this change
cross compile x11vnc to i686 linux musl static
Things done
Tested on top of #89471
Tested that x11vnc still compile on x86_64-linux
Tested that a slightly modified x11vnc cross compiles to x86_64 musl static and i686 musl static
(I removed systemd and libgcrypt optional dependencies from libvncserver)
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)