I would like to work on this issue but how would you eliminate duplication here?

Hi, I'd also like to work on this if possible.

It looks like GetMinimapOwner in screenshot.cpp returns the Owner based on the tile given, and that is then used in MinimapScreenCallback to get the colour of the tile. This code seems to have been duplicated from GetSmallMapOwnerPixels in smallmap_gui.cpp, which returns the colour of the tile for the small map, with very little difference.

This could possibly be put into a new file, or an existing one, tasked with getting a colour for a specific world tile, which both the screenshot file and small map file could use instead.

I'm new to open source and OpenTTD development so please let me know if I got anything wrong or if there's a better solution!

I honestly suspect none of the devs really looked into it, as that most likely would also result in a solution :P But what you describe sounds good, but we won't really know till we see the code :D

I would say, just give it a spin, and make a Pull Request when you think it is done. We take it from there :)

As for new file or existing, I would go with an existing one. Finding a good place might be a bit tricky, but between the 500+ files we have I am sure it fits in one of them :D

Thanks for the very quick response!

Yep, I'll try and work on a proper coded solution and open a PR when I think it's ready, as well as try to find somewhere the code could go.

Is it all good if I work on this issue ? I might not start this month since I have some stuff going on though.

No need to ask permission. Just do it and open a Pull Request. 🙂