Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runc: 1.0.0-rc90 -> 1.0.0-rc91 #91979

Merged
merged 2 commits into from Jul 5, 2020
Merged

runc: 1.0.0-rc90 -> 1.0.0-rc91 #91979

merged 2 commits into from Jul 5, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jul 2, 2020

https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc91

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vdemeester
vdemeester approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

saschagrunert
saschagrunert approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adisbladis
adisbladis previously requested changes Jul 2, 2020
View reviewed changes
pkgs/applications/virtualization/runc/default.nix Outdated Show resolved Hide resolved
@zowoq zowoq marked this pull request as draft July 2, 2020 08:29
@zowoq zowoq marked this pull request as ready for review July 2, 2020 08:42
@zowoq zowoq dismissed adisbladis’s stale review July 2, 2020 08:43

reverted to buildGoPackage

@zowoq
Copy link
Contributor Author

zowoq commented Jul 2, 2020

@ofborg test podman

@ofborg ofborg bot added the 6.topic: nixos label Jul 2, 2020
@bhipple
Copy link
Contributor

bhipple commented Jul 5, 2020

Result of nixpkgs-review pr 91979 1

6 packages built:
- buildah
- cri-o
- k3s
- podman
- runc
- udocker

@bhipple bhipple merged commit f688b2b into NixOS:master Jul 5, 2020
@zowoq zowoq deleted the runc branch July 16, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@adisbladis adisbladis Awaiting requested review from adisbladis

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zowoq @bhipple @vdemeester @adisbladis @saschagrunert