Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teams: 1.3.00.5152 -> 1.3.00.16851 #91966

Merged
merged 1 commit into from Jul 3, 2020
Merged

teams: 1.3.00.5152 -> 1.3.00.16851 #91966

merged 1 commit into from Jul 3, 2020

Conversation

devhell
Copy link
Contributor

@devhell devhell commented Jul 1, 2020

Microsoft finally released a new version for Linux.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@devhell
teams: 1.3.00.5152 -> 1.3.00.16851
6450f9e 
Microsoft finally released a new version for Linux.
@devhell
Copy link
Contributor Author

devhell commented Jul 1, 2020

@GrahamcOfBorg build teams

@devhell devhell requested a review from liff July 1, 2020 18:38
@Mic92 Mic92 merged commit 83ad051 into NixOS:master Jul 3, 2020
@Mic92
Copy link
Member

Mic92 commented Jul 3, 2020

Should we backport teams updates since they depend on external services?

@devhell devhell deleted the update-teams branch July 3, 2020 15:48
@devhell
Copy link
Contributor Author

devhell commented Jul 3, 2020

Should we backport teams updates since they depend on external services?

I think that's a very good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liff liff liff approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devhell @Mic92 @liff