Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.tinycss2: remove failing lint test #91967

Merged
merged 1 commit into from Jul 1, 2020
Merged

pythonPackages.tinycss2: remove failing lint test #91967

merged 1 commit into from Jul 1, 2020

Conversation

colemickens
Copy link
Member

Motivation for this change

Fix tinycss2. Unblocks #84150.

Although I have to say, I'm confused. This caused a fairly large rebuild for something seemingly broken?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author 


[colemickens@aarch64:~/nixpkgs]$ nixpkgs-review rev 'ad778fa7d00ecfd5a858321a0b4f151fa8dbc49c'
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/colemickens/.cache/nixpkgs-review/rev-ad778fa7d00ecfd5a858321a0b4f151fa8dbc49c-1/nixpkgs 55668eb671b915b49bcaaeec4518cc49d8de0a99
Preparing worktree (detached HEAD 55668eb671b)
Updating files: 100% (22017/22017), done.
HEAD is now at 55668eb671b inxi: 3.1.03-1 -> 3.1.04-1
$ nix-env -f /home/colemickens/.cache/nixpkgs-review/rev-ad778fa7d00ecfd5a858321a0b4f151fa8dbc49c-1/nixpkgs -qaP --xml --out-path --show-trace
^[[2~
$ git merge --no-commit ad778fa7d00ecfd5a858321a0b4f151fa8dbc49c
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/colemickens/.cache/nixpkgs-review/rev-ad778fa7d00ecfd5a858321a0b4f151fa8dbc49c-1/nixpkgs -qaP --xml --out-path --show-trace --meta
14 packages updated:
metasrht python3.7-CairoSVG python3.7-cssselect2 python3.7-pygal python3.7-tinycss2 python3.7-weasyprint python3.7-xml2rfc python3.8-CairoSVG python3.8-cssselect2 python3.8-pygal python3.8-tinycss2 python3.8-weasyprint python3.8-xml2rfc xml2rfc

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/colemickens/.cache/nixpkgs-review/rev-ad778fa7d00ecfd5a858321a0b4f151fa8dbc49c-1/build.nix
13 packages built:
python37Packages.cairosvg python37Packages.cssselect2 python37Packages.pygal python37Packages.tinycss2 python37Packages.weasyprint python37Packages.xml2rfc python38Packages.cairosvg python38Packages.cssselect2 python38Packages.pygal python38Packages.tinycss2 python38Packages.weasyprint xml2rfc sourcehut.metasrht

$ nix-shell /home/colemickens/.cache/nixpkgs-review/rev-ad778fa7d00ecfd5a858321a0b4f151fa8dbc49c-1/shell.nix

[nix-shell:~/.cache/nixpkgs-review/rev-ad778fa7d00ecfd5a858321a0b4f151fa8dbc49c-1]$

jonringer
jonringer approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 91967 1

13 packages built: - python37Packages.cairosvg - python37Packages.cssselect2 - python37Packages.pygal - python37Packages.tinycss2 - python37Packages.weasyprint - python37Packages.xml2rfc - python38Packages.cairosvg - python38Packages.cssselect2 - python38Packages.pygal - python38Packages.tinycss2 - python38Packages.weasyprint - xml2rfc (python38Packages.xml2rfc) - sourcehut.metasrht

@jonringer jonringer merged commit 3ddf576 into NixOS:master Jul 1, 2020
@lopsided98 lopsided98 mentioned this pull request Jul 6, 2020
Merged
10 tasks
@colemickens colemickens deleted the tinycss2 branch December 30, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @jonringer