Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tint2: fix doc directory #91949

Merged
merged 2 commits into from Jul 2, 2020
Merged

tint2: fix doc directory #91949

merged 2 commits into from Jul 2, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jul 1, 2020 •
edited

Motivation for this change
  • Format with nixpkgs-fmt.
  • Use pkg-config instead of pkgconfig
  • Do not explicitly enable parallel building, as it is automatically enabled for cmake projects
  • Fix doc directory. Documentation files should not be installed directly at $out/share/doc because they may collide with files from other packages when paths are linked in the system environment.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
tint2: format with nixpkgs-fmt
5f21dfd 
Also:
- use pkg-config instead of pkgconfig
- do not explicitly enable parallel building, as its automatically
enabled for cmake projects
@romildo
tint2: fix doc directory
5c021a4 
Documentation files should not be installed directly at $out/share/doc
because they may collide with files from other packages when paths are
linked in the system environment.
danieldk
danieldk approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 91949 1

1 package built:
- tint2

Output path looks good.

@danieldk danieldk merged commit d2fd808 into NixOS:master Jul 2, 2020
@romildo romildo deleted the fix.tint2 branch July 2, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @danieldk