Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zstd: build programs and tests against the shared library #91984

Merged
merged 1 commit into from Jul 14, 2020
Merged

zstd: build programs and tests against the shared library #91984

merged 1 commit into from Jul 14, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jul 2, 2020 •
edited

Motivation for this change

7f76daa introduces a regression where cmake still exports zstd_static library, but the file doesn't exist anymore. In the discussion #90218 (comment) it was also pointed out that we are not testing the libraries that we are using.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl added this to WIP in Staging via automation Jul 2, 2020
@veprbl veprbl moved this from WIP to Needs review in Staging Jul 2, 2020
@veprbl veprbl requested review from vcunat and Ericson2314 July 2, 2020 04:27
Staging automation moved this from Needs review to Ready Jul 2, 2020
@veprbl veprbl mentioned this pull request Jul 6, 2020
Closed
10 tasks
lopsided98 referenced this pull request Jul 6, 2020
@vcunat
zstd: get rid of static libs if enableShared
7f76daa
@veprbl veprbl merged commit ac94f1a into NixOS:staging Jul 14, 2020
Staging automation moved this from Ready to Done Jul 14, 2020
@veprbl veprbl deleted the pr/zstd_use_shared_lib branch July 14, 2020 20:34
@ludovicc
Copy link

@veprbl I'd like some help to fix the build for arrow-cpp which fails on Darwin because of zstd (#93202)

@veprbl veprbl restored the pr/zstd_use_shared_lib branch December 1, 2020 16:46
@veprbl veprbl deleted the pr/zstd_use_shared_lib branch December 1, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat left review comments

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@veprbl @ludovicc @Ericson2314 @vcunat