Fix CSS typed OM CSSSkewX and CSSSkewY toMatrix method to use degrees instead of radians. #24418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 1, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2242008
branch
from
016f1e3
to
6d566b1
Compare
… instead of radians. The toMatrix method of a CSSTransformComponent should return a DOMMatrix representing the object transformation. https://www.w3.org/TR/css-typed-om-1/#dom-csstransformcomponent-tomatrix The skewXSelf and skewYSelf methods used to apply a transformation on a matrix must be provided with an angle parameter expressed in degrees. https://www.w3.org/TR/geometry-1/#dom-dommatrix-skewxself https://www.w3.org/TR/geometry-1/#dom-dommatrix-skewyself Since the angles passed to the skewXSelf and skewYSelf were in radians, DOMMatrix returned by the toMatrix method of those two components was incorrect. R=alancutter@chromium.org Change-Id: I5edc1cdf1493184584154723508c6e20c212ac92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242008 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#786632}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2242008
branch
from
6d566b1
to
4fb426b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toMatrix method of a CSSTransformComponent should return a DOMMatrix
representing the object transformation.
https://www.w3.org/TR/css-typed-om-1/#dom-csstransformcomponent-tomatrix
The skewXSelf and skewYSelf methods used to apply a transformation on a
matrix must be provided with an angle parameter expressed in degrees.
https://www.w3.org/TR/geometry-1/#dom-dommatrix-skewxself
https://www.w3.org/TR/geometry-1/#dom-dommatrix-skewyself
Since the angles passed to the skewXSelf and skewYSelf were in radians,
DOMMatrix returned by the toMatrix method of those two components was incorrect.
R=alancutter@chromium.org
Change-Id: I5edc1cdf1493184584154723508c6e20c212ac92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242008
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786632}