Run the tests in parallel #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cause the time needed to run the testsuite to drop from ~4mins to ~40s
Use a fifo pipe to handle the synchronisation between the different threads rather than relying on delays
Use a fifo pipe to handle the synchronisation between the different threads rather than relying on delays
|
Thanks, awesome :-) |
|
Bleh, this broke OSX tests because the socket path becomes too long on the CI 😒 I'll open a MR to increase its length |
|
I got this running |
|
Mh nvm, I can't do that, the size is defined in glibc 🤦 I'll just try and shorten a bit the |
Mh I was indeed missing a dependency. |
thufschmitt
added a commit
to tweag/nix
that referenced
this pull request
Jul 2, 2020
Reuse the pre-existing list rather than the one written as part of NixOS#3777
Merged
|
#3778 fixes the |
|
YAY!!!!! Wow, I hindsight I have no idea how I survived the past month without this :) Thanks @regnat!!! |
thufschmitt
added a commit
to tweag/nix
that referenced
this pull request
Jul 3, 2020
Reuse the pre-existing list rather than the one written as part of NixOS#3777
Ericson2314
pushed a commit
to obsidiansystems/nix
that referenced
this pull request
Nov 24, 2021
Reuse the pre-existing list rather than the one written as part of NixOS#3777 (cherry picked from commit 5101ed1)
Ericson2314
pushed a commit
to obsidiansystems/nix
that referenced
this pull request
Nov 30, 2021
Reuse the pre-existing list rather than the one written as part of NixOS#3777 (cherry picked from commit 5101ed1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the way the testsuite runs to make each test a separate make target, allowing to run them in parallel rather than sequentially as we do now.
This causes
make installcheck -j$(nproc)to drop from ~4m30 to ~40s on my machine.To allow that, each test now runs under a different
TEST_ROOT(which also ensures that they are truly independant), and runstests/init.shfirst to setup everything