Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulnix: 1.9.4 -> 1.9.6 #92001

Merged
merged 1 commit into from Jul 7, 2020
Merged

vulnix: 1.9.4 -> 1.9.6 #92001

merged 1 commit into from Jul 7, 2020

Conversation

ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Jul 2, 2020

Motivation for this change

vulnix: 1.9.4 -> 1.9.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Ubuntu)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

lsix
lsix approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested. All good for me.

lsix
lsix requested changes Jul 2, 2020
View reviewed changes
pkgs/tools/security/vulnix/default.nix Outdated Show resolved Hide resolved
@Ma27 Ma27 mentioned this pull request Jul 2, 2020
Closed
10 tasks
jonringer
jonringer reviewed Jul 3, 2020
View reviewed changes
pkgs/tools/security/vulnix/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/vulnix/default.nix Outdated Show resolved Hide resolved
@ckauhaus
Copy link
Contributor Author

ckauhaus commented Jul 3, 2020

reworking to PR...

@ckauhaus
Copy link
Contributor Author

ckauhaus commented Jul 3, 2020

better?

jonringer
jonringer approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/92001
1 package built:
vulnix

@jonringer jonringer merged commit 711e47a into NixOS:master Jul 7, 2020
@ckauhaus ckauhaus deleted the vulnix-1.9.6 branch July 10, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix requested changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ckauhaus @lsix @jonringer