Codechange #8258: Remove unused town cargo caches from the savegame #8258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
previously approved these changes
Jul 2, 2020
ldpl
added a commit
to ldpl/OpenTTD
that referenced
this pull request
Jul 2, 2020
ldpl
force-pushed
the
remove-town-cargo-from-save
branch
from
6aa8c57
to
df048eb
Compare
LordAro
previously approved these changes
Jul 3, 2020
ldpl
added a commit
to ldpl/OpenTTD
that referenced
this pull request
Jul 7, 2020
ldpl
force-pushed
the
remove-town-cargo-from-save
branch
from
df048eb
to
947a662
Compare
ldpl
force-pushed
the
remove-town-cargo-from-save
branch
from
947a662
to
f15c551
Compare
|
Just removed TODO I forgot |
LordAro
approved these changes
Jul 10, 2020
Milek7
added a commit
to Milek7/OpenTTD
that referenced
this pull request
Dec 15, 2020
… the savegame" This reverts commit 452e1e3.
Milek7
added a commit
to Milek7/OpenTTD
that referenced
this pull request
Dec 15, 2020
… the savegame" This reverts commit 452e1e3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove from the savegame Town::cargo_accepted and Town::cargo_produced that were made obsolete by #8159. Also while at it I removed 30 reserved bytes for each town that somehow survived the dff871b purge.
I considered also removing TileMatrix/AcceptanceMatrix but decided to leave it be for now even though atm it's only used to read matrix dimensions as it's still a nice structure that can be useful in the future.