Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pmix: init at 3.1.5, add support to slurm, openmpi #92048

Merged
merged 4 commits into from Jul 9, 2020
Merged

pmix: init at 3.1.5, add support to slurm, openmpi #92048

merged 4 commits into from Jul 9, 2020

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Jul 2, 2020 •
edited

Motivation for this change

Unlock the full potential of Slurm. By adding PMIx, Slurm now fully supports running MPI binaries with srun instead of mpirun.

Addresses also ideas from #79771

Things done
  • init pmix
  • build slurm with PMIx support
  • build openmpi against PMIx support
  • add a PMIx test case to nixos/tests/slurm.nix
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jagajaga July 2, 2020 13:52
@markuskowa markuskowa merged commit 6ce0442 into NixOS:master Jul 9, 2020
@markuskowa markuskowa deleted the add-pmix branch July 9, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@ikervagyok ikervagyok ikervagyok approved these changes

@jagajaga jagajaga Awaiting requested review from jagajaga

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: nixos 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @veprbl @ikervagyok