Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] ceph: 14.2.9 -> 14.2.10 #91989

Merged
merged 1 commit into from Jul 2, 2020
Merged

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jul 2, 2020

Add new dependency on rdkafka
Also removed now-obsolete cve patch as it's integrated already

(cherry picked from commit a1f6898)
Backport of #91919

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Add new dependency on rdkafka
Also removed now-obsolete cve patch as it's integrated already

(cherry picked from commit a1f6898)
Backport of NixOS#91919
@srhb
Copy link
Contributor Author

srhb commented Jul 2, 2020

@ofborg test ceph-single-node ceph-multi-node

Copy link
Contributor

@johanot johanot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@srhb
Copy link
Contributor Author

srhb commented Jul 2, 2020

Hmm, just noticed sambaFull may still be failing here, and that went away on master after a rebase. Trying that here as well, but maybe 20.03 is missing something, investigating.

@srhb srhb marked this pull request as draft July 2, 2020 11:11
@srhb
Copy link
Contributor Author

srhb commented Jul 2, 2020

@ofborg build sambaFull

@srhb srhb marked this pull request as ready for review July 2, 2020 15:56
@srhb
Copy link
Contributor Author

srhb commented Jul 2, 2020

According to ofBorg, sambaFull is fine after the rebase. All good.

@srhb srhb merged commit 1af2655 into NixOS:release-20.03 Jul 2, 2020
@srhb srhb deleted the backport-ceph-14.2.10 branch July 3, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants