Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.coq-bits: enable for Coq 8.11 and 8.12 #91990

Merged
merged 1 commit into from Jul 9, 2020
Merged

coqPackages.coq-bits: enable for Coq 8.11 and 8.12 #91990

merged 1 commit into from Jul 9, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jul 2, 2020

Motivation for this change

This library is compatible with recent versions of Coq.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl vbgl requested a review from Ptival July 2, 2020 06:29
@vbgl vbgl merged commit f6db90a into NixOS:master Jul 9, 2020
@vbgl vbgl deleted the coq-bits-8.12 branch July 9, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ptival Ptival Awaiting requested review from Ptival

Assignees
No one assigned
Labels
6.topic: coq 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vbgl