Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whirlpool-gui: init at 0.10.1 #92009

Merged
merged 1 commit into from Jul 3, 2020
Merged

whirlpool-gui: init at 0.10.1 #92009

merged 1 commit into from Jul 3, 2020

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

Add whrilpool-gui app.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@offlinehacker offlinehacker force-pushed the pkgs/whirlpool-gui/init/0.10.1 branch from c86741a to 89c5275 Compare July 3, 2020 07:20
@mmahut
Copy link
Member

mmahut commented Jul 3, 2020

Tested, works fine, thank you.

@mmahut mmahut merged commit 5ca432d into NixOS:master Jul 3, 2020
@offlinehacker
Copy link
Contributor Author

offlinehacker commented Jul 3, 2020 •
edited

Hmm looks like I forgot to put homepage in quotes as is required according to rfc.

@mmahut
Copy link
Member

mmahut commented Jul 3, 2020

Hmm looks like I forgot to put homepage in quotes as is required according to rfc.

Yes, I did comment on it, but was not sure if it is already in RFC. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@offlinehacker @mmahut