Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pygogo: init at 0.13.2 #91981

Merged
merged 2 commits into from Jul 13, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Add a useful python logging library/application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor Author

@danieldk would you mind reviewing?

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review PR fails with:

builder for '/nix/store/9rx0vab2k0pbj2al86kcfraxcv7nh95x-python2.7-pkutils-1.1.0.drv' failed with exit code 1; last 10 log lines:
      TypeError: Expected str or VersionInfo instance, but got <type 'unicode'>
  
  
  Name         Stmts   Miss  Cover
  --------------------------------
  pkutils.py      86     11    87%
  ----------------------------------------------------------------------
  Ran 12 tests in 0.020s
  
  FAILED (failures=3)
cannot build derivation '/nix/store/kd40g88p01m2g7kn339dirz54mhkvxi3-env.drv': 1 dependencies couldn't be built

pkgs/development/python-modules/pygogo/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 91981 1

4 packages built: - python37Packages.pkutils - python37Packages.pygogo - python38Packages.pkutils - python38Packages.pygogo

@jonringer jonringer merged commit 7e8d919 into NixOS:master Jul 13, 2020
@drewrisinger drewrisinger deleted the dr-pr-pygogo branch July 13, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants