Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enlightenment: setuid missing path #91980

Merged
merged 1 commit into from Jul 6, 2020
Merged

enlightenment: setuid missing path #91980

merged 1 commit into from Jul 6, 2020

Conversation

bagnaram
Copy link
Contributor

@bagnaram bagnaram commented Jul 2, 2020 •
edited

Motivation for this change

e_util_setuid has the path hardcoded for which applications it allows to execute using setuid bit.
This patch fixes Trying to rfkill unblock the bluetooth adapter failed dialogs that occur whenever ACPI awakes occur.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bagnaram bagnaram changed the title enlightenment: setuid missing path WIP: enlightenment: setuid missing path Jul 2, 2020
@bagnaram
enlightenment: enlightenment setuid path patch
f3d1a4f 
(add correct nix path to setuid utility)
@bagnaram bagnaram changed the title WIP: enlightenment: setuid missing path enlightenment: setuid missing path Jul 2, 2020
@romildo romildo merged commit fcb0630 into NixOS:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romildo romildo romildo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagnaram @romildo