Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btlejack: init at 2.0.0 #92045

Merged
merged 1 commit into from Mar 21, 2021
Merged

btlejack: init at 2.0.0 #92045

merged 1 commit into from Mar 21, 2021

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Jul 2, 2020 •
edited

Motivation for this change

This PR adds the btlejack tool with its dependencies and transitive dependencies:

Edit: The dependencies were added in the meantime.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxzi oxzi requested review from FRidh and jonringer as code owners July 2, 2020 13:18
@oxzi oxzi changed the title Btlejack 2.0.0 btlejack: init at 2.0.0 Jul 2, 2020
jonringer
jonringer reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to enable unit tests for the packages if possible.

use pythonImportsCheck otherwise

pkgs/development/python-modules/halo/default.nix Outdated Show resolved Hide resolved
@oxzi
Copy link
Member Author

oxzi commented Feb 8, 2021 •
edited

I have rebased this PR another time. In the meantime, halo, log-symbols, and spinners were added via #110565.

Edit: I also removed the cursor package, as it was only required for a transitive dependency. Thus, this PR is now down to just adding btlejack.

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit 0ec1f94 into NixOS:master Mar 21, 2021
@oxzi oxzi deleted the btlejack-2.0.0 branch March 22, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxzi @SuperSandro2000 @jonringer @ryantm