Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hitch: add passthru.tests #92198

Merged
merged 1 commit into from Jul 3, 2020
Merged

hitch: add passthru.tests #92198

merged 1 commit into from Jul 3, 2020

Conversation

jflanglois
Copy link
Contributor

@jflanglois jflanglois commented Jul 3, 2020 •
edited

Motivation for this change

Make the associated nixos test run any time this package is updated (e.g. through auto version updates).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor

bhipple commented Jul 3, 2020

Result of nixpkgs-review pr 92198 1

@bhipple bhipple merged commit 7264165 into NixOS:master Jul 3, 2020
@jflanglois jflanglois deleted the hitch-passthru-tests branch July 4, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jflanglois @bhipple