Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to latest release (https://github.com/dbcli/mycli/blob/master/changelog.md#1211).
Currently the
setup.py
restrictsprompt_toolkit to < 3.0
. Upstream has adjusted the supported version range to>=3.0.0,<4.0.0
a few days after the 1.21.1 release.I did try the tool with the current prompt_toolkit version in nixpkgs and noticed no obvious problems. The
postPatch
should be removed with the next upstream release.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)