Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mycli: 1.20.1 -> 1.21.1 #91927

Merged
merged 1 commit into from Jul 2, 2020
Merged

mycli: 1.20.1 -> 1.21.1 #91927

merged 1 commit into from Jul 2, 2020

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented Jul 1, 2020

Motivation for this change

Update to latest release (https://github.com/dbcli/mycli/blob/master/changelog.md#1211).

Currently the setup.py restricts prompt_toolkit to < 3.0. Upstream has adjusted the supported version range to >=3.0.0,<4.0.0 a few days after the 1.21.1 release.

I did try the tool with the current prompt_toolkit version in nixpkgs and noticed no obvious problems. The postPatch should be removed with the next upstream release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/6xxp4vd31cpsvhkjij7n3knc52xfihd8-mycli-1.20.1	  172056576
/nix/store/nndmxssy3xljzxhfl8cjvqrlc2p4hrcs-mycli-1.21.1	  172307888

Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM.
  • Builds cleanly via nix-review pr 91927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants