Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.denonavr: 0.8.1 -> 0.9.3 #92208

Merged
merged 1 commit into from Jul 3, 2020
Merged

pythonPackages.denonavr: 0.8.1 -> 0.9.3 #92208

merged 1 commit into from Jul 3, 2020

Conversation

colemickens
Copy link
Member

Motivation for this change

Update to latest stable, in attempt to fix denonavr integration in home-assistant 0.112.x.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author 

[colemickens@aarch64:~/nixpkgs]$ nixpkgs-review rev 0b75b8fe570b282bd31bcbaec97b58eb4d701504
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 51, done.
remote: Counting objects: 100% (51/51), done.
remote: Compressing objects: 100% (31/31), done.
remote: Total 67 (delta 26), reused 25 (delta 18), pack-reused 16
Unpacking objects: 100% (67/67), 260.65 KiB | 2.33 MiB/s, done.
From https://github.com/NixOS/nixpkgs
...
$ git worktree add /home/colemickens/.cache/nixpkgs-review/rev-0b75b8fe570b282bd31bcbaec97b58eb4d701504/nixpkgs f7c7509ecd0a49a2a7402cebb89351166bb136d2
Preparing worktree (detached HEAD f7c7509ecd0)
Updating files: 100% (22019/22019), done.
HEAD is now at f7c7509ecd0 Merge pull request #91655 from davegallant/master
$ nix-env -f /home/colemickens/.cache/nixpkgs-review/rev-0b75b8fe570b282bd31bcbaec97b58eb4d701504/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 0b75b8fe570b282bd31bcbaec97b58eb4d701504
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/colemickens/.cache/nixpkgs-review/rev-0b75b8fe570b282bd31bcbaec97b58eb4d701504/nixpkgs -qaP --xml --out-path --show-trace --meta
3 packages updated:
python27Packages.denonavr (0.8.1 → 0.9.3) python37Packages.denonavr (0.8.1 → 0.9.3) python38Packages.denonavr (0.8.1 → 0.9.3)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/colemickens/.cache/nixpkgs-review/rev-0b75b8fe570b282bd31bcbaec97b58eb4d701504/build.nix
[3 built, 35 copied (20.3 MiB), 3.7 MiB DL]
3 packages built:
python27Packages.denonavr python37Packages.denonavr python38Packages.denonavr

$ nix-shell /home/colemickens/.cache/nixpkgs-review/rev-0b75b8fe570b282bd31bcbaec97b58eb4d701504/shell.nix

[nix-shell:~/.cache/nixpkgs-review/rev-0b75b8fe570b282bd31bcbaec97b58eb4d701504]$

jonringer
jonringer approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 92208 1

3 packages built: - python27Packages.denonavr - python37Packages.denonavr - python38Packages.denonavr

@jonringer jonringer merged commit 06c7787 into NixOS:master Jul 3, 2020
@colemickens colemickens deleted the denonavr branch December 30, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @jonringer