Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libhandy: 0.0.13 -> 1.0.0 #92204

Closed
wants to merge 1 commit into from
Closed

libhandy: 0.0.13 -> 1.0.0 #92204

wants to merge 1 commit into from

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Update libhandy (latest elementary onboarding needs it). I did run into an issue getting the tests to pass in the hdy-avatar.
It seems to be something gdk-pixbuf/librsvg related? I left the output in the comment in the expression.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from jtojnar and hedning July 3, 2020 18:44
@jtojnar
Copy link
Contributor

jtojnar commented Jul 4, 2020

Looks to be very breaking change: https://gitlab.gnome.org/GNOME/libhandy/-/tags/v0.80.0

@worldofpeace worldofpeace mentioned this pull request Jul 7, 2020
Merged
10 tasks
@worldofpeace
Copy link
Contributor Author

Result of nixpkgs-review 1

26 packages failed to build:
- adapta-gtk-theme
- calls
- chrome-gnome-shell
- contrast
- epiphany
- fractal
- gnome-podcasts
- gnome3.bijiben
- gnome3.geary
- gnome3.gnome-calendar
- gnome3.gnome-clocks
- gnome3.gnome-control-center
- gnome3.gnome-session
- gnome3.gnome-shell
- gnome3.gnome-terminal
- gnome3.gnome-tweak-tool
- gnome3.pomodoro
- gnome3.seahorse
- gnomeExtensions.gsconnect
- pantheon.elementary-greeter
- pantheon.elementary-gsettings-schemas
- pantheon.elementary-onboarding
- pantheon.elementary-session-settings
- pantheon.wingpanel-applications-menu
- pantheon.wingpanel-with-indicators
- shortwave
2 packages built:
- gnome3.gnome-contacts
- libhandy

@ranfdev
Copy link
Contributor

ranfdev commented Jul 12, 2020 •
edited

26 packages failed to build

Is it possible to merge this PR anyway, or someone has to patch/update all 26 packages?

@jtojnar
Copy link
Contributor

jtojnar commented Jul 12, 2020

We would either need to patch them, or provide package of two different versions of libhandy. Though I believe this is still not a stable version so not many things should depend on it.

@worldofpeace
Copy link
Contributor Author

Not sure if Bump API version to 1.0.0. denotes a stable version now. Given that it's now under the gnome umbrella, I've noticed the elementary projects have already made the switch to require this new version.

@jtojnar
Copy link
Contributor

jtojnar commented Jul 12, 2020

I would expect this to be a pre-pre-release for 1.0, since pre-releases are typically 0.90.

@pbogdan pbogdan mentioned this pull request Aug 21, 2020
Closed
@colemickens
Copy link
Member

libhandy is at 0.90.0 now, btw. (I am bumping it for myself for cchat-gtk)

@onny
Copy link
Contributor

onny commented Sep 14, 2020

Two days ago libhandy 1.0 released :) https://gitlab.gnome.org/GNOME/libhandy/-/releases

@worldofpeace
Copy link
Contributor Author

Thx, will finish this up for that.

@worldofpeace worldofpeace changed the title libhandy: 0.0.13 -> 0.83.0 libhandy: 0.0.13 -> 1.0.0 Sep 14, 2020
@worldofpeace
Copy link
Contributor Author

Okay, updated. I believe we'll just merge this into the gnome-3.38 branch. Due https://wiki.gnome.org/ThreePointThirtyseven#d2020-09-16

@jtojnar
Copy link
Contributor

jtojnar commented Sep 15, 2020

There are many third party packages that will likely not have updated when GNOME 3.38 is released so we will probably still need libhandy_0.

@worldofpeace
Copy link
Contributor Author

This is included in #98316 with the libhandy_0 package.

@worldofpeace worldofpeace deleted the update-libhandy branch September 20, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@worldofpeace @jtojnar @ranfdev @colemickens @onny