Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.coq-extensible-records: remove at 1.2.0 #92139

Merged
merged 2 commits into from Jul 10, 2020
Merged

coqPackages.coq-extensible-records: remove at 1.2.0 #92139

merged 2 commits into from Jul 10, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jul 3, 2020

Motivation for this change

This library is compatible with recent versions of Coq.

cc maintainer @Ptival

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ptival
Copy link
Contributor

Ptival commented Jul 3, 2020

@vbgl this library is not being maintained, I wonder whether we should just remove it rather than rely on me keeping my "fork" up to date?

@vbgl
Copy link
Contributor Author

vbgl commented Jul 3, 2020

Do you think that there are users of this library that would be pleased to have it packaged here? If not, then let’s remove it.

@Ptival
Copy link
Contributor

Ptival commented Jul 5, 2020

I honestly don't think anyone is using it. Do you want me to remove it, or are you doing it?

@vbgl
Copy link
Contributor Author

vbgl commented Jul 5, 2020

Thanks. I’ll just update this PR to remove the package.

@vbgl vbgl force-pushed the coq-extensible-records-8.12 branch from f8c0807 to 9852fc5 Compare July 5, 2020 19:33
@vbgl vbgl changed the title coqPackages.coq-extensible-records: enable for Coq 8.11 and 8.12 coqPackages.coq-extensible-records: remove at 1.2.0 Jul 5, 2020
@vbgl vbgl merged commit d1a7237 into NixOS:master Jul 10, 2020
@vbgl vbgl deleted the coq-extensible-records-8.12 branch July 10, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: coq 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @Ptival