gradle: 5.6.4 -> 6.5.1 #92103
Merged
gradle: 5.6.4 -> 6.5.1 #92103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
|
@ludovicc thanks for opening your first pr to nixpkgs :) |
jonringer
reviewed
Jul 2, 2020
| nativeVersion = "0.22"; | ||
|
|
||
| src = fetchurl { | ||
| url = "http://services.gradle.org/distributions/${name}-bin.zip"; |
There was a problem hiding this comment.
I get a 403:
builder for '/nix/store/v34wfmafk54chdkascgsycwmsdnw1ypc-gradle-6.5.1-bin.zip.drv' failed with exit code 1; last 7 log lines:
trying http://services.gradle.org/distributions/gradle-6.5.1-bin.zip
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (22) The requested URL returned error: 403 Forbidden
error: cannot download gradle-6.5.1-bin.zip from any mirror
|
@jonringer Thanks for the welcome and the review. It looks like you had some kind of transient error while downloading the zip, http://services.gradle.org/distributions/gradle-6.5.1-bin.zip works both from browser and using nix-review on this pr. |
danieldk
reviewed
Jul 3, 2020
|
I use https for all urls as suggested. |
jonringer
reviewed
Jul 3, 2020
Co-authored-by: Daniël de Kok <me@github.danieldk.eu> Use https for all urls fix version for native library pin gradle for jd-gui
|
jd-gui should work better, I pinned gradle to version 5 as used by this package. |
jonringer
reviewed
Jul 4, 2020
| @@ -1,4 +1,4 @@ | |||
| { stdenv, fetchFromGitHub, jre, jdk, gradle, makeDesktopItem, perl, writeText, runtimeShell }: | |||
| { stdenv, fetchFromGitHub, jre, jdk, gradle_5, makeDesktopItem, perl, writeText, runtimeShell }: | |||
There was a problem hiding this comment.
the gradle_5 pinning should probably be done in another commit
There was a problem hiding this comment.
jd-gui: pin gradle to 5.X
gradle: 5.6.4 -> 6.5.1
10 tasks
|
@jonringer I have moved the gradle_5 pinning to #92292, this pr is now dependant on #92292 |
jonringer
approved these changes
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upgrade Gradle to latest version 6.5.1
Add gradle_6 to the top level packages.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)