Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dpic: cleanup derivation, install man pages #92171

Merged
merged 1 commit into from Jul 4, 2020
Merged

dpic: cleanup derivation, install man pages #92171

merged 1 commit into from Jul 4, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jul 3, 2020

Motivation for this change
  • Use configure, since upstream provides it.
  • Rely on make install to install dpic.
  • This also installs the man pages.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
dpic: cleanup derivation, install man pages
f3e9518 
- Use configure, since upstream provides it.
- Rely on `make install` to install dpic.
- This also installs the man pages.
@ofborg ofborg bot requested a review from aespinosa July 3, 2020 12:16
aespinosa
aespinosa approved these changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@aespinosa aespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danieldk
Copy link
Contributor Author

danieldk commented Jul 4, 2020

Thanks for the review! I also checked darwin.

@danieldk danieldk merged commit b5f9d86 into NixOS:master Jul 4, 2020
@danieldk danieldk deleted the dpic-cleanup branch July 4, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aespinosa aespinosa aespinosa approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @aespinosa