Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brasero: added cdrtools dependency. #92143

Closed
wants to merge 1 commit into from
Closed

brasero: added cdrtools dependency. #92143

wants to merge 1 commit into from

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Jul 3, 2020 •
edited

Motivation for this change

Fixes: #92087

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasj19 dasj19 mentioned this pull request Jul 3, 2020
Open
@ofborg ofborg bot requested a review from bdimcheff July 3, 2020 08:23
@jtojnar
Copy link
Contributor

jtojnar commented Jul 3, 2020 •
edited

Related #14871 and http://cdrtools.sourceforge.net/private/linux-dist.html

@dasj19 dasj19 changed the title brasero: added cdrkit library. brasero: added cdrtools dependency. Jul 7, 2020
@dasj19
Copy link
Contributor Author

dasj19 commented Jul 7, 2020

@jtojnar I replaced cdrkit with cdrtools and brasero works as expected.
Should we on the long term remove cdrkit from the repo and replace every occurence with cdrtools?

@jtojnar
Copy link
Contributor

jtojnar commented Jul 7, 2020

That is weird, cdrtools are actually used in the wrapper:

https://github.com/NixOS/nixpkgs/blob/daec48f47c050789e182dce61ea349d11a80968a/pkgs/tools/cd-dvd/brasero/wrapper.nix

Edit: oh, right the wrapper did not update the desktop files to point to the wrapped executable.

@dasj19
Copy link
Contributor Author

dasj19 commented Jul 7, 2020

Also I just opened: #92585 on brasero

@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 29, 2020 00:57
@SuperSandro2000 SuperSandro2000 added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Nov 29, 2020
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@dasj19 dasj19 mentioned this pull request Jan 4, 2022
Merged
13 tasks
@Artturin
Copy link
Member

Artturin commented Feb 2, 2023

Reopen and rebase if you're still interested in this.

@Artturin Artturin closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdimcheff bdimcheff Awaiting requested review from bdimcheff

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brasero: can't make 1-to-1 copy of discs
4 participants
@dasj19 @jtojnar @Artturin @SuperSandro2000