Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd: use latest ffmpeg #92080

Merged
merged 1 commit into from Jul 3, 2020
Merged

mpd: use latest ffmpeg #92080

merged 1 commit into from Jul 3, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Jul 2, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was unable to build saga due to missing headers:

opencv.h:75:10: fatal error: opencv/cv.h: No such file or directory
   75 | #include <opencv/cv.h>
      |          ^~~~~~~~~~~~~
compilation terminated.
make[5]: *** [Makefile:550: opencv_ml_tools.lo] Error 1
make[5]: *** [Makefile:550: opencv_fourier.lo] Error 1
make[5]: *** [Makefile:550: opencv_morphology.lo] Error 1
make[5]: *** [Makefile:550: opencv_nnet.lo] Error 1
make[5]: *** [Makefile:550: opencv_ml.lo] Error 1
make[5]: *** [Makefile:550: opencv_svd.lo] Error 1
make[5]: Leaving directory '/build/saga-7.6.3/src/tools/imagery/imagery_opencv'
make[4]: *** [Makefile:411: all-recursive] Error 1
make[4]: Leaving directory '/build/saga-7.6.3/src/tools/imagery'
make[3]: *** [Makefile:411: all-recursive] Error 1
make[3]: Leaving directory '/build/saga-7.6.3/src/tools'
make[2]: *** [Makefile:411: all-recursive] Error 1
make[2]: Leaving directory '/build/saga-7.6.3/src'
make[1]: *** [Makefile:517: all-recursive] Error 1
make[1]: Leaving directory '/build/saga-7.6.3'
make: *** [Makefile:428: all] Error 2

@doronbehar
Copy link
Contributor Author

Oops, didn't intent to add that saga commit. Let's see what ofborg says only about mpd.

@Mic92
Copy link
Member

Mic92 commented Jul 3, 2020

Result of nixpkgs-review pr 92080 1

1 package built:
- mpd

@Mic92 Mic92 merged commit a85443e into NixOS:master Jul 3, 2020
@doronbehar doronbehar deleted the mpd-ffmpeg4 branch March 2, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants