Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portfolio: 0.46.3 -> 0.46.6 #92174

Merged
merged 1 commit into from Jul 6, 2020
Merged

portfolio: 0.46.3 -> 0.46.6 #92174

merged 1 commit into from Jul 6, 2020

Conversation

oyren
Copy link
Contributor

@oyren oyren commented Jul 3, 2020

Motivation for this change

Update of portfolio performance to 0.46.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from elohmeier July 3, 2020 12:57
@elohmeier
Copy link
Contributor

Thanks @oyren ✨

danieldk
danieldk approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nitpicks:

  • The list of maintainers was indented with spaces + \t (use spaces only). Besides that, two maintainers are still ok to have on one line.
  • In the commit message for packages, use the attribute name (here: portfolio: ...).

But since these are really small changes, I have updated the PR myself. Thanks for the update!

Result of nixpkgs-review pr 92174 1

1 package built:
- portfolio

@danieldk danieldk changed the title PortfolioPerformance: 0.46.3 -> 0.46.6 portfolio: 0.46.3 -> 0.46.6 Jul 6, 2020
@danieldk danieldk merged commit 13b8f41 into NixOS:master Jul 6, 2020
@oyren
Copy link
Contributor Author

oyren commented Jul 6, 2020

Two small nitpicks:

* The list of maintainers was indented with spaces + `\t` (use spaces only). Besides that, two maintainers are still ok to have on one line.

* In the commit message for packages, use the attribute name (here: `portfolio: ...`).

But since these are really small changes, I have updated the PR myself. Thanks for the update!

Result of nixpkgs-review pr 92174 1
1 package built:

  • portfolio

Thanks, I'll keep an eye on it next time.

@oyren oyren deleted the update-portfolio branch July 6, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@elohmeier elohmeier elohmeier approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oyren @elohmeier @danieldk