{cc,bintools}-wrapper: Some fixes #92089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we can freely keep the comments up to date without the penalty of a mass rebuild.
This will unbreak firefox and a few other packages which try to grab some of the libcxx flags.
10 tasks
vcunat
reviewed
Jul 2, 2020
| @@ -228,58 +231,56 @@ stdenv.mkDerivation { | |||
| *) echo "Multiple dynamic linkers found for platform '${targetPlatform.config}'." >&2;; | |||
| esac | |||
|
|
|||
| if [ -n "''${dynamicLinker:-}" ]; then | |||
| if [ -n "''${dynamicLinker-}" ]; then | |||
There was a problem hiding this comment.
I'm mainly curious... this dash is some kind of special operator? I can't find this one in man bash.
There was a problem hiding this comment.
@vcunat See https://wiki.bash-hackers.org/syntax/pe#use_a_default_value
If you omit the
:(colon), like shown in the second form, the default value is only used when the parameter was unset, not when it was empty.
There was a problem hiding this comment.
Thanks. Now I also read that man bash part again – more properly – and I see it there as well 🤦
ofborg
bot
requested review from
davidtwco,
matthewbauer,
Lucus16,
peti,
Synthetica9 and
veprbl
vcunat
approved these changes
Jul 2, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This means we can freely keep the comments up to date without the penalty of a mass rebuild.
This will unbreak firefox and a few other packages which try to grab some of the libcxx flags.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)