Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ferdi: init at 5.5.0; franz: 5.4.1 -> 5.5.0 #92155

Merged
merged 2 commits into from Jul 8, 2020
Merged

ferdi: init at 5.5.0; franz: 5.4.1 -> 5.5.0 #92155

merged 2 commits into from Jul 8, 2020

Conversation

davidtwco
Copy link
Member

@davidtwco davidtwco commented Jul 3, 2020 •
edited

Motivation for this change

Add a package for Ferdi, a fork of Franz which is already packaged. In addition, this updates Franz to the most recent release, 5.5.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Jul 5, 2020

Just an FYI: the way this is written now, it won't be able to be updated with nixpkgs-update/r-ryantm because it has two packages with two src derivations in the same file. If you want automatic updates, please consider splitting it into three files, one with the generic builder and one for each of the packages.

@davidtwco davidtwco changed the title ferdi: init at 5.5.0 ferdi: init at 5.5.0; franz: 5.4.1 -> 5.5.0 Jul 6, 2020
@davidtwco
Copy link
Member Author

Just an FYI: the way this is written now, it won't be able to be updated with nixpkgs-update/r-ryantm because it has two packages with two src derivations in the same file. If you want automatic updates, please consider splitting it into three files, one with the generic builder and one for each of the packages.

This should be fixed now, thanks!

ryantm
ryantm requested changes Jul 8, 2020
View reviewed changes
pkgs/build-support/franz/default.nix Outdated Show resolved Hide resolved
@ryantm
Copy link
Member

ryantm commented Jul 8, 2020

@GrahamcOfBorg build ferdi franz

ryantm
ryantm approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ryantm ryantm merged commit c3fb5d8 into NixOS:master Jul 8, 2020
@marsam marsam mentioned this pull request Jul 9, 2020
Closed
@davidtwco davidtwco deleted the ferdi-init branch July 9, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtwco @ryantm