Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc-wrapper: ensure existence of some $out/nix-support/* #92086

Closed
wants to merge 1 commit into from
Closed

cc-wrapper: ensure existence of some $out/nix-support/* #92086

wants to merge 1 commit into from

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Jul 2, 2020

Done because of f3f7612. Now it's possible to simply use
$(< ${stdenv.cc}/nix-support/libcxx-cxxflags)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • :-) Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
cc-wrapper: ensure existence of some $out/nix-support/*
b64db33 
Done because of f3f7612.  Now it's possible to simply use
$(< ${stdenv.cc}/nix-support/libcxx-cxxflags)
@vcunat vcunat requested a review from Ericson2314 as a code owner July 2, 2020 19:16
vcunat referenced this pull request Jul 2, 2020
@Ericson2314
C++ Compilers: Systematize handling of standard libraries
f3f7612
@vcunat vcunat mentioned this pull request Jul 2, 2020
Closed
10 tasks
@vcunat
Copy link
Member Author

vcunat commented Jul 2, 2020

This sounds quite safe to me, so it seems more a question of which approach to choose exactly. I'm now running rebuilds with it anyway.

@Ericson2314
Copy link
Member

Ericson2314 commented Jul 2, 2020 •
edited

Sorry! I made the branch with the fix and ran the tests, and then forgot to open the PR. Opened now in #92089

@vcunat
Copy link
Member Author

vcunat commented Jul 2, 2020

OK, better use that, I expect. I've given it almost no thought.

@vcunat vcunat closed this Jul 2, 2020
@vcunat vcunat deleted the p/cc-wrapper-flag-files branch July 2, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@peti peti Awaiting requested review from peti

@davidtwco davidtwco Awaiting requested review from davidtwco

@Lucus16 Lucus16 Awaiting requested review from Lucus16

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@veprbl veprbl Awaiting requested review from veprbl

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vcunat @Ericson2314