Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paraview: Fix dataset filtering #92113

Merged
merged 1 commit into from Dec 16, 2020
Merged

paraview: Fix dataset filtering #92113

merged 1 commit into from Dec 16, 2020

Conversation

AshyIsMe
Copy link
Contributor

@AshyIsMe AshyIsMe commented Jul 3, 2020

Paraview requires python and numpy to be available at runtime not just
build time. Filtering a csv dataset uses numpy and throws an error
without python and numpy being available in the propagatedBuildInputs.

Motivation for this change

Paraview requires python and numpy to be available at runtime not just
build time. Filtering a csv dataset uses numpy and throws an error
without python and numpy being available in the propagatedBuildInputs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AshyIsMe
paraview: Fix dataset filtering
2586530 
Paraview requires python and numpy to be available at runtime not just
build time.  Filtering a csv dataset uses numpy and throws an error
without python and numpy being available in the propagatedBuildInputs.
@ofborg ofborg bot requested a review from dguibert July 3, 2020 00:54
@JJJollyjim
Copy link
Member

Can't test due to non-nixos OpenGL issues, but lgtm.

@doronbehar doronbehar merged commit 9196e0d into NixOS:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguibert dguibert Awaiting requested review from dguibert

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AshyIsMe @JJJollyjim @doronbehar