Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubespy: init at 0.5.1 #92197

Merged
merged 2 commits into from Jul 6, 2020
Merged

kubespy: init at 0.5.1 #92197

merged 2 commits into from Jul 6, 2020

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Jul 3, 2020 •
edited

Motivation for this change

A tool to observe Kubernetes resource in real time
closes #92196

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@blaggacao blaggacao marked this pull request as draft July 3, 2020 17:54
@blaggacao blaggacao changed the title WIP: kubespy: init at 0.5.1 kubespy: init at 0.5.1 Jul 3, 2020
@blaggacao blaggacao force-pushed the da-add-kubespy branch 2 times, most recently from f027d8e to 55a3205 Compare July 3, 2020 19:11
@blaggacao blaggacao marked this pull request as ready for review July 3, 2020 20:50
@blaggacao blaggacao force-pushed the da-add-kubespy branch 2 times, most recently from 662f96b to 0790c39 Compare July 3, 2020 21:06
@blaggacao
Copy link
Contributor Author

blaggacao commented Jul 3, 2020 •
edited

figuring out build issue upstream: pulumi/kubespy#73
My bad.

@ofborg ofborg bot requested a review from kalbasit July 3, 2020 23:58
@blaggacao
Copy link
Contributor Author

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 4, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 4, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@blaggacao
Copy link
Contributor Author

/status awaiting_reviewer

@ludovicc
Copy link

ludovicc commented Jul 5, 2020

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on Darwin
  • executables tested on Darwin
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Possible improvements
Comments

Tested only execution of kubespy with no arguments, it prints help for the command.

@blaggacao
Copy link
Contributor Author

blaggacao commented Jul 6, 2020 •
edited

@ludovicc thank you a lot for this review on my first PR to nixpkgs.

@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 6, 2020

Sorry, you cannot set your own PR to needs_merger or awaiting_merger. Please wait for an external review. You may also actively search out a reviewer by pinging relevant people (look at the history of the files you're changing) or posting on discourse or IRC.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/215

jonringer
jonringer reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/applications/networking/cluster/kubespy/default.nix Outdated Show resolved Hide resolved
kubespy: init at 0.5.1
89b8786 
A tool to observe Kubernetes resources in real time.

This is uesful, among others, for "staffing" shell.nix environments for k8s projects.
jonringer
jonringer approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

https://github.com/NixOS/nixpkgs/pull/92197
1 package built:
kubespy

@jonringer jonringer merged commit e1b48ea into NixOS:master Jul 6, 2020
@timokau timokau mentioned this pull request Jul 6, 2020
Merged
@Luflosi
Copy link
Contributor

Luflosi commented Jul 6, 2020

Minor nitpick: this PR added two extra spaces in an otherwise empty line in pkgs/top-level/all-packages.nix. This isn't the case anywhere else in this file.

@blaggacao
Copy link
Contributor Author

@Luflosi Thanks for hinting, looks like I might need to tweak my nix-lsp.

blaggacao pushed a commit to xoe-labs/syndesis that referenced this pull request Jul 7, 2020
chore: unlock kubespy in shell.nix
56b4c39 
since merge of NixOS/nixpkgs#92197
blaggacao pushed a commit to xoe-labs/syndesis that referenced this pull request Aug 18, 2020
chore: unlock kubespy in shell.nix
9e83ff5 
since merge of NixOS/nixpkgs#92197
blaggacao pushed a commit to xoe-labs/syndesis that referenced this pull request Aug 18, 2020
chore: unlock kubespy in shell.nix
6a1b45f 
since merge of NixOS/nixpkgs#92197
@blaggacao blaggacao deleted the da-add-kubespy branch August 27, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add kubespy
6 participants
@blaggacao @ludovicc @nixos-discourse @Luflosi @jonringer @Janik-Haag